Compose Firebase InAppMessaging#1498
Merged
thatfiredev merged 2 commits intofirebase:composefrom Mar 6, 2026
Merged
Conversation
- Transferred business logic to ViewModel sharable to the `KotlinMainActivity` and `ComposeMainActivity`
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a Jetpack Compose implementation to the Firebase In-App Messaging quickstart. It introduces a ComposeMainActivity and a shared InAppMessagingViewModel to handle logic, which is a solid architectural choice. The existing KotlinMainActivity is also refactored to use this new ViewModel, improving code structure and reusability. My review includes suggestions for improving accessibility, removing hardcoded strings, and refining some of the new Kotlin and Compose code.
| } | ||
|
|
||
| companion object { | ||
| private const val TAG = "Compose-FIAM-Quickstart" |
There was a problem hiding this comment.
The TAG constant is declared but never used within ComposeMainActivity. It can be removed to clean up the code.
...messaging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/ComposeMainActivity.kt
Show resolved
Hide resolved
...messaging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/ComposeMainActivity.kt
Outdated
Show resolved
Hide resolved
...messaging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/ComposeMainActivity.kt
Outdated
Show resolved
Hide resolved
...messaging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/ComposeMainActivity.kt
Show resolved
Hide resolved
...aging/app/src/main/java/com/google/firebase/fiamquickstart/kotlin/InAppMessagingViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Jetpack compose option to the Firebase In-App Messaging quickstart.
@thatfiredev